This repository was archived by the owner on Dec 21, 2021. It is now read-only.
4. Refactor Publish #164
Merged
4. Refactor Publish #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoxley
changed the base branch from
master
to
promisify-subscription-methods
This was referenced Sep 17, 2020
timoxley
force-pushed
the
refactor-publish
branch
from
a63b03a to
db3cbd2
Compare
…. 1000x calls with ethers: 14s, randomBytes: 3.5ms.
timoxley
force-pushed
the
promisify-subscription-methods
branch
from
2615d55 to
d73804d
Compare
timoxley
force-pushed
the
refactor-publish
branch
from
db3cbd2 to
7ae593c
Compare
mirpo
approved these changes
Sep 21, 2020
src/utils.js
Outdated
| } | ||
|
|
||
| /* eslint-disable object-curly-newline */ | ||
| export function CacheAsyncFn(fn, { |
harbu
approved these changes
Oct 22, 2020
src/Publisher.js
Outdated
| constructor(client) { | ||
| this.client = client | ||
| const cacheOptions = client.options.cache | ||
| this.msgChainer = new OrderedMessageChainCreator(cacheOptions) |
Contributor
There was a problem hiding this comment.
Constructor of OrderedMessageChainCreator takes no arguments?
…event backdated messages silently breaking future publishes (#166) * Improve authFetch logging. * Update message sequencer to strictly enforce message order. * Queue publishes per-stream otherwise can skip forward then back even when messages published in correct sequence. * Add partial solution to broken backdated messages, at least doesn't break regular sequential publishes. * Tidy up, add some comments. * Move publish queue fn into utils.
timoxley
added a commit
that referenced
this pull request
Nov 24, 2020
* Promisify subscribe/unsubscribe. * Fail _request call if unsubscribe/subscribe request fails to send. * Fix missing import in resend test. * Fix browser tests. * Clean up unused function in test. * 4. Refactor Publish (#164) * Refactor & co-locate publish code. * Avoid using expensive ethers.Wallet.createRandom() calls in test. e.g. 1000x calls with ethers: 14s, randomBytes: 3.5ms. * Ensure messageCreationUtil is cleaned up after test. * Fix non-functional MessageCreationUtil test. * Swap out receptacle for more flexible mem/p-memoize/quick-lru. * Convert LoginEndpoints test to async/await. * Remove calls to ensureConnected/ensureDisconnected in test. * 5. Message Sequencing – Guarantee sequence follows publish order & Prevent backdated messages silently breaking future publishes (#166) * Improve authFetch logging. * Update message sequencer to strictly enforce message order. * Queue publishes per-stream otherwise can skip forward then back even when messages published in correct sequence. * Add partial solution to broken backdated messages, at least doesn't break regular sequential publishes. * Tidy up, add some comments. * Move publish queue fn into utils.
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-locating and re-jigging publishing step.
Also:
mem,p-memoize&quick-lruethers.Wallet.createRandom()call in tests.ensureConnected/ensureDisconnected.Builds on: